Refactoring of the dictionary building infrastructure removed the EventDef.h header. This PR just removes that header and includes the specific event objects needed for the processors instead.
In addition, I remove the RootSimFromEcalSP generator for the following reasons. In general, I think it would be better to start from scratch, perhaps with a modification to the ReSimulator rather than using a generator with the plain simulator.
It uses the EventFile::close function which has been removed from Framework in favor of a close-on-destruct method.
It has not been used (to my knowledge) in years, so even if it was compile-time patched, I'm unsure if it is functional.
The logic within this generator is a bit suspicious to me, I am unsure if it is getting all of the particles leaving the ECal and/or if it is using the same particle multiple times.
The updated re-simulation infrastructure accomodates this by allowing users to choose which events to re-simulate and update the HCal geometry such that the changed geometry will see the same events that were interesting in previous geometries.
https://github.com/LDMX-Software/ldmx-sw/pull/1251 for context.
Refactoring of the dictionary building infrastructure removed the
EventDef.hheader. This PR just removes that header and includes the specific event objects needed for the processors instead.In addition, I remove the
RootSimFromEcalSPgenerator for the following reasons. In general, I think it would be better to start from scratch, perhaps with a modification to the ReSimulator rather than using a generator with the plain simulator.EventFile::closefunction which has been removed from Framework in favor of a close-on-destruct method.