search

LDMX-Software / SimCore

Integration of Geant4 simulation framework into a more generalized event processing framework.
2 stars 0 forks source link

Load biasing operators dynamically (like UserActions, PrimaryGenerators, etc...) #15

Closed tomeichlersmith closed 3 years ago

tomeichlersmith commented 4 years ago

The base class XsecBiasingOperator already does most of the work interfacing with Geant4, so we can have our derived classes instead be modified to be "biasing calculators" or something similar that are dynamically loaded into the XsecBiasingOperator and then specific functions can be called.

omar-moreno commented 4 years ago

I'm in the process of rewriting how DetectorConstruction works to make it more flexible to adding other detector description packages. I can take care of this as part of that rewrite.

tomeichlersmith commented 4 years ago

Please check if the biasing operators (after changing them to be dynamically loaded) could be moved to the Biasing module. It just makes more sense to me from an organizational point of view to have the biasing operators and the filters in the Biasing module.

omar-moreno commented 4 years ago

I'll check. Doing this was creating a circular dependency before, but maybe this isn't an issue anymore.

Also, some of these are generic enough that they can be used by other biasing modules in the future. Putting them in Biasing would prevent us from doing so. I'll look into which of these can be moved without causing issues to other frameworks.

On Thu, Jul 9, 2020 at 11:27 AM Tom Eichlersmith notifications@github.com wrote:

Please check if the biasing operators (after changing them to be dynamically loaded) could be moved to the Biasing module. It just makes more sense to me from an organizational point of view to have the biasing operators and the filters in the Biasing module.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/LDMX-Software/SimCore/issues/15#issuecomment-656282475, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4JMXDIBBGIQ6HMYCORPOTR2YD2LANCNFSM4OV2WEJQ .