LDMX-Software / SimCore

Integration of Geant4 simulation framework into a more generalized event processing framework.
2 stars 0 forks source link

modify volume names for attaching to ecal volumes during biasing #81

Closed tomeichlersmith closed 2 years ago

tomeichlersmith commented 2 years ago

We changed the names of some of the ECal volumes in the GDML for readability, we need to update those names in the biasing attachment (similar to how SDs are attached).

To Do

tomeichlersmith commented 2 years ago

I tested that this didn't break anything by compiling trunk of ldmx-sw with this branch of SimCore. Then I ran the ecal_pn validation sample for v14 and v12 (by changing the config).

cd ldmx-sw
git switch trunk
git submodule update
cd SimCore
git switch ecal-biasing-attach
cd ../
# build and install
cd .github/validation_samples/ecal_pn
ldmx setenv LDMX_RUN_NUMBER=1
ldmx setenv LDMX_NUM_EVENTS=10
ldmx fire config.py
# edit config to be v12 instead of v14 geometry
ldmx fire config.py

Both geometries attached the biasing operators to the correct volumes in the ECal.

I did not check the updates to isInHcal besides make sure it can compile.

The LV parent tree... doesn't really exist. PVs have mothers, but LVs aren't placed yet so they don't really have a parent-child relationship.