LDMX-Software / TrigScint

1 stars 3 forks source link

Tweaks to make simulation reconstruction closer to data #42

Closed bryngemark closed 2 years ago

bryngemark commented 2 years ago

This PR includes making hit reconstruction integrate over the full number of time samples, and a few minor bug fixes such as correct pedestal subtraction and zero suppression.

Also it reduces the QIEDigi verbosity which was an old issue.

Closes #41 and closes #21 .

bryngemark commented 2 years ago

I have now added in functionality that will also take care of event cleaning. So, also closes #43

bryngemark commented 2 years ago

@awhitbeck, is there anything else you'd like to see or can we have this merged? You have to approve in that case.