LDMX-Software / docker

Docker build context for developing and running ldmx-sw.
https://ldmx-software.github.io/docker/
GNU General Public License v3.0
1 stars 2 forks source link

Docker labels derived from env variables set once per dependency #80

Closed bryngemark closed 10 months ago

bryngemark commented 10 months ago

I am changing stuff in the Dockerfile, here are the details.

What new packages does this PR add to the development container?

None. Instead it makes sure we define labels based on the same version number variable as we use for building the container. This closes #77 .

Check List

bryngemark commented 10 months ago

I can get to the ldmx-sw building tests next week.

bryngemark commented 10 months ago

@tomeichlersmith there is a disk space issue preventing the CI build. Do we have a cleanup scheme for old containers, or are they always wiped between attempts?

tomeichlersmith commented 10 months ago

The old containers should be wiped but I manually removed the cache now. I am uncertain why there was still caches left, maybe due to the failed builds? I don't know.

bryngemark commented 10 months ago

Ok. Would it make sense to add whatever you did to clear the cache to the end of the CI workflow? It's awesome to profit from the cache to save on build time but if all we get is space problems, then it's not working for us.

bryngemark commented 10 months ago

Running the tests set up in the different modules uncovered a whole lot of issues -- but they look like the tests haven't been updated in a while. I'll make an issue. I did manage to successfully run e.g. the ecal PN test.

tomeichlersmith commented 10 months ago

The cache-clearing is already at the end of the CI workflow, I don't think it is called if the build fails and ends the workflow early, I need to look into if we can always clear the cache in some way.

https://github.com/LDMX-Software/docker/blob/93cad7ece7c84fc99f4f9a9bafb2192858ef90e6/.github/workflows/ci.yml#L65-L72