Add missing boost targets to CMake config.

I added the targets as they came up while compiling. I can try removing the framework target to see if it still builds.

OS: Centos7 GCC: 8.3.1 Python: 3.9 HDF5: trunk HighFive: trunk

On Tue, May 24, 2022 at 1:37 PM Tom Eichlersmith @.***> wrote:

@.**** requested changes on this pull request.

Good catch! Not sure why I haven't seen this in the systems I've been testing on. Besides the comment I have, I'm also curious what system you are testing on (OS, compiler, Boost, Python, and HDF5 versions) so that I can integrate that into the CI testing.

In CMakeLists.txt https://github.com/LDMX-Software/fire/pull/37#discussion_r880927952:

@@ -126,7 +126,7 @@ add_library(framework SHARED src/fire/Conditions.cxx src/fire/RandomNumberSeedService.cxx ) -target_link_libraries(framework PUBLIC logging version exception config factory io) +target_link_libraries(framework PUBLIC logging version exception config factory io Boost::boost)

This additional link shouldn't be needed since Boost::boost is already included in config and factory as a PUBLIC dependency. Did you add it after seeing that it didn't work without it? Or did you add it because framework uses some boost headers occasionally?

— Reply to this email directly, view it on GitHub https://github.com/LDMX-Software/fire/pull/37#pullrequestreview-983822064, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4JMXGXSSB5IR6HW7S54NTVLU4YNANCNFSM5W2XDKDQ . You are receiving this because you were assigned.Message ID: @.***>

LDMX-Software / fire

Add missing boost targets to CMake config. #37

Good catch! Not sure why I haven't seen this in the systems I've been testing on. Besides the comment I have, I'm also curious what system you are testing on (OS, compiler, Boost, Python, and HDF5 versions) so that I can integrate that into the CI testing.