search

LDS-Gamers-Studios / icarus5

Custom bot for the LDS Gamers Community
MIT License
7 stars 5 forks source link

Create banner.js #190

Open BobbyTheCatfish opened 2 years ago

BobbyTheCatfish commented 2 years ago

This makes it easy and consistent for holiday banners to be set. A template has been added to the shared testing Google Sheet. Make sure to not have a leading zero when adding dates

Maldor commented 2 years ago

Will need to see the example sheet to see what is exactly expected for the code to work. Looks pretty simple, but also could be simple to mess up if we error out somewhere in setting the banner.

BobbyTheCatfish commented 2 years ago

The sheet is pinned in the testing channel

Maldor commented 2 years ago

Sheet reviewed. Looks good to me, I would request that the code check for a valid date before attempting to apply the image, this may come in handy once we get the Mop Bucket awards back on track for applying the house banner to the page. Is this supposed to run daily?

Essentially: Is date present? y/n If no, do not apply image, check next entry If yes, apply image, exit from code

BobbyTheCatfish commented 2 years ago

If there is no date present, the image won't be added to the collection, making it impossible for it to be applied. Yes this runs daily. image

Since the system finds a current banner via the current date, invalid/incomplete dates won't be able to be found and thus won't be applied

Maldor commented 2 years ago

Alright cool. This has Discord Manager sign off (not that I get to much of a veto anyway 😄)