search

LDflex / Query-Solid

Simple access to data in Solid pods through LDflex expressions
https://solid.github.io/query-ldflex/
MIT License
66 stars 15 forks source link

npm audit fix #61

Closed angelo-v closed 4 years ago

angelo-v commented 4 years ago

Just ran npm audit fix to fix vulnerabilities

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 173

Totals Coverage Status
Change from base Build 170: 0.0%
Covered Lines: 136
Relevant Lines: 136
💛 - Coveralls
angelo-v commented 4 years ago

The build error is weird. I can reproduce it with node v13.13.0 on my local machine, but it also fails on master with that node version. With v13.12.0 both master and my PR are building without problem.

RubenVerborgh commented 4 years ago

Thanks. It's likely a 13-specific error that will resolve itself over time.

Shall we maybe for simplicity close this one? I always update the packages anyway before a version bump, and package-lock.json only affects dev, not production.

angelo-v commented 4 years ago

Hmm, I usually do it the other way arround, to not start developing new stuff based on outdated versions. If something breaks like here I would have suspected my changes to be the cause. But it's fine for me if you prefer otherwise

RubenVerborgh commented 4 years ago

Is these changes indeed, but indirectly; some other package broke in an in-range update. I assume they will fix, given that it’s Babel.

RubenVerborgh commented 4 years ago

The package in question was fixed; did a full lockfile update in c8e8362f3b797e794336c631a0c1937d91206918.