search

LEDApplications / DEPRECATED-lehd-schema

The draft version of the lehd schema: https://lehd.ces.census.gov/data/schema/
https://ledapplications.github.io/lehd-schema/
Creative Commons Zero v1.0 Universal
0 stars 0 forks source link

Validate/Update Versions and Dates #22

Closed jodyhoonstarr closed 4 years ago

jodyhoonstarr commented 4 years ago

Check and update superseded versions and date timestamps if needed.

srt1 commented 4 years ago

I see - I didn't realize what this ticket was intended for. I will include the comment listed in #23, and close that.

Changes from 4.6.0

Adding PSEO data product
jodyhoonstarr commented 4 years ago

Did you still want all the stuff in the 4.5.0-draft changes? Or clear that out too?

Changes from 4.5.0-draft

  • Additional status flags on PSEO Earnings
  • Additional measures on PSEO Flows to report unobserved/marginally employed
  • Earnings reported at 2-digit CIPCODE level
  • Institution code changed to 8-digits
  • Updated to 2020 CIPCODE
srt1 commented 4 years ago

Those changes are relevant for the primary schema page, but not relevant for the "file naming convention" page. And I think you could say that we added those naming convention changes in 4.5.0-draft, so there is effectively no difference between 4.5.0-draft and 4.7.0. So what we want to say here is that we are incorporating the PSEO changes from the draft into the official branch - so it's changes from 4.6.0.

From: Jody Hoon-Starr notifications@github.com Sent: Thursday, July 2, 2020 2:40 PM To: LEDApplications/lehd-schema lehd-schema@noreply.github.com Cc: Stephen R Tibbets (CENSUS/CES FED) Stephen.R.Tibbets@census.gov; Comment comment@noreply.github.com Subject: Re: [LEDApplications/lehd-schema] Validate/Update Versions and Dates (#22)

Did you still want all the stuff in the 4.5.0-draft changes? Or clear that out too?

Changes from 4.5.0-draft

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/LEDApplications/lehd-schema/issues/22#issuecomment-653163824, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFMXFIKTYZ3RCVUAYCKR3YLRZTIA7ANCNFSM4ONP373Q.

srt1 commented 4 years ago

The only reason to keep them would have been if the "changes from" was static, and could not be vary across the different pages. If it has to be the same, keep the whole thing. If it can vary, make it relevant for the page you are looking at.

From: Stephen R Tibbets (CENSUS/CES FED) Stephen.R.Tibbets@census.gov Sent: Thursday, July 2, 2020 2:43 PM To: LEDApplications/lehd-schema reply@reply.github.com Subject: Re: [LEDApplications/lehd-schema] Validate/Update Versions and Dates (#22)

Those changes are relevant for the primary schema page, but not relevant for the "file naming convention" page. And I think you could say that we added those naming convention changes in 4.5.0-draft, so there is effectively no difference between 4.5.0-draft and 4.7.0. So what we want to say here is that we are incorporating the PSEO changes from the draft into the official branch - so it's changes from 4.6.0.

From: Jody Hoon-Starr notifications@github.com Sent: Thursday, July 2, 2020 2:40 PM To: LEDApplications/lehd-schema lehd-schema@noreply.github.com Cc: Stephen R Tibbets (CENSUS/CES FED) Stephen.R.Tibbets@census.gov; Comment comment@noreply.github.com Subject: Re: [LEDApplications/lehd-schema] Validate/Update Versions and Dates (#22)

Did you still want all the stuff in the 4.5.0-draft changes? Or clear that out too?

Changes from 4.5.0-draft

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/LEDApplications/lehd-schema/issues/22#issuecomment-653163824, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFMXFIKTYZ3RCVUAYCKR3YLRZTIA7ANCNFSM4ONP373Q.

srt1 commented 4 years ago

... at least, that's what makes sense to me. I didn't design the system, so I sometimes have to infer the intent, and don't always get it right.

From: Stephen R Tibbets (CENSUS/CES FED) Stephen.R.Tibbets@census.gov Sent: Thursday, July 2, 2020 2:45 PM To: LEDApplications/lehd-schema reply@reply.github.com Subject: Re: [LEDApplications/lehd-schema] Validate/Update Versions and Dates (#22)

The only reason to keep them would have been if the "changes from" was static, and could not be vary across the different pages. If it has to be the same, keep the whole thing. If it can vary, make it relevant for the page you are looking at.

From: Stephen R Tibbets (CENSUS/CES FED) Stephen.R.Tibbets@census.gov Sent: Thursday, July 2, 2020 2:43 PM To: LEDApplications/lehd-schema reply@reply.github.com Subject: Re: [LEDApplications/lehd-schema] Validate/Update Versions and Dates (#22)

Those changes are relevant for the primary schema page, but not relevant for the "file naming convention" page. And I think you could say that we added those naming convention changes in 4.5.0-draft, so there is effectively no difference between 4.5.0-draft and 4.7.0. So what we want to say here is that we are incorporating the PSEO changes from the draft into the official branch - so it's changes from 4.6.0.

From: Jody Hoon-Starr notifications@github.com Sent: Thursday, July 2, 2020 2:40 PM To: LEDApplications/lehd-schema lehd-schema@noreply.github.com Cc: Stephen R Tibbets (CENSUS/CES FED) Stephen.R.Tibbets@census.gov; Comment comment@noreply.github.com Subject: Re: [LEDApplications/lehd-schema] Validate/Update Versions and Dates (#22)

Did you still want all the stuff in the 4.5.0-draft changes? Or clear that out too?

Changes from 4.5.0-draft

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/LEDApplications/lehd-schema/issues/22#issuecomment-653163824, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFMXFIKTYZ3RCVUAYCKR3YLRZTIA7ANCNFSM4ONP373Q.

jodyhoonstarr commented 4 years ago

Right now there's a single static changes.txt that gets tacked onto the end of every page. We can split it out to individual files easily if we care to detail the changelist for each section. It takes minimal technical effort, the only question is whether we want to maintain it.

srt1 commented 4 years ago

Your call. Not a big deal, then.

From: Jody Hoon-Starr notifications@github.com Sent: Thursday, July 2, 2020 2:50 PM To: LEDApplications/lehd-schema lehd-schema@noreply.github.com Cc: Stephen R Tibbets (CENSUS/CES FED) Stephen.R.Tibbets@census.gov; Comment comment@noreply.github.com Subject: Re: [LEDApplications/lehd-schema] Validate/Update Versions and Dates (#22)

Right now there's a single static changes.txt that gets tacked onto the end of every page. We can split it out to individual files easily if we care to detail the changelist for each section. It takes minimal technical effort, the only question is whether we want to maintain it.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/LEDApplications/lehd-schema/issues/22#issuecomment-653167967, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFMXFIP2LGRBKN2SLRUESHDRZTJGDANCNFSM4ONP373Q.

srt1 commented 4 years ago

Heath the other primary owner of this, and I generally don't like to specify those kind of structural changes without his input, so I can happily table it.

From: Stephen R Tibbets (CENSUS/CES FED) Stephen.R.Tibbets@census.gov Sent: Thursday, July 2, 2020 2:55 PM To: LEDApplications/lehd-schema reply@reply.github.com Subject: Re: [LEDApplications/lehd-schema] Validate/Update Versions and Dates (#22)

Your call. Not a big deal, then.

From: Jody Hoon-Starr notifications@github.com Sent: Thursday, July 2, 2020 2:50 PM To: LEDApplications/lehd-schema lehd-schema@noreply.github.com Cc: Stephen R Tibbets (CENSUS/CES FED) Stephen.R.Tibbets@census.gov; Comment comment@noreply.github.com Subject: Re: [LEDApplications/lehd-schema] Validate/Update Versions and Dates (#22)

Right now there's a single static changes.txt that gets tacked onto the end of every page. We can split it out to individual files easily if we care to detail the changelist for each section. It takes minimal technical effort, the only question is whether we want to maintain it.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/LEDApplications/lehd-schema/issues/22#issuecomment-653167967, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFMXFIP2LGRBKN2SLRUESHDRZTJGDANCNFSM4ONP373Q.

heathhayward commented 4 years ago

I'm happy with whatever solution is the easiest to maintain going forward. I agree that it's a bit weird to mention shapefile changes on the "naming" page, but the changes section refers to schema version changes, not page changes. But if it's easy to maintain separate change files, then I'm down with that approach.

srt1 commented 4 years ago

It's likely that for the majority of schema version updates, there will be no change to the "naming conventions" page - so the "changes from" for that page would be blank, if we made the section independent from the primary schema page. So presumably, someone would have to remember to update it. If we think we can maintain separate sections, we can do that; otherwise, keep it as-is.

Thanks.

From: heathhayward notifications@github.com Sent: Monday, July 6, 2020 9:45 AM To: LEDApplications/lehd-schema lehd-schema@noreply.github.com Cc: Stephen R Tibbets (CENSUS/CES FED) Stephen.R.Tibbets@census.gov; Comment comment@noreply.github.com Subject: Re: [LEDApplications/lehd-schema] Validate/Update Versions and Dates (#22)

I'm happy with whatever solution is the easiest to maintain going forward. I agree that it's a bit weird to mention shapefile changes on the "naming" page, but the changes section refers to schema version changes, not page changes. But if it's easy to maintain separate change files, then I'm down with that approach.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/LEDApplications/lehd-schema/issues/22#issuecomment-654248197, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFMXFIK2EZ5QII5GQ2N6WO3R2HIQPANCNFSM4ONP373Q.

jodyhoonstarr commented 4 years ago

Split out files can be seen here (clear your cache if they all look the same):

Feel free to request any changes to the items seen there.

srt1 commented 4 years ago

That all looks fine to me. I don't follow the shapefiles one, so fill that in as appropriate. If it's the same as 4.6.0, you can probably put "No changes" or "None."

I'll sign off on 4.7.0 - feel free to push to the website whenever you are ready. Thanks for putting this all together.

From: Jody Hoon-Starr notifications@github.com Sent: Monday, July 6, 2020 11:35 AM To: LEDApplications/lehd-schema lehd-schema@noreply.github.com Cc: Stephen R Tibbets (CENSUS/CES FED) Stephen.R.Tibbets@census.gov; Comment comment@noreply.github.com Subject: Re: [LEDApplications/lehd-schema] Validate/Update Versions and Dates (#22)

Split out files can be seen here (clear your cache if they all look the same):

Feel free to request any changes to the items seen there.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/LEDApplications/lehd-schema/issues/22#issuecomment-654311103, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFMXFIJVV4ILKN3VWNSOLN3R2HVMNANCNFSM4ONP373Q.

heathhayward commented 4 years ago

Yep, this is fine as it is.