LESEM-PEWI / pewi3.0

People in Ecosystems Watershed Integration v4
https://www.nrem.iastate.edu/pewi/pewi4/
GNU Affero General Public License v3.0
1 stars 24 forks source link

Combined PR for 753, 754, 755, 756, 757, 760, 761 #759

Closed nbatwara closed 3 years ago

nbatwara commented 3 years ago

754, #755

tomtinkerer commented 3 years ago

@nbatwara #754 and #755 are good to go! However, #753 (bubble graphic updates) are not showing on my end.

image

nbatwara commented 3 years ago

competed #760, #761. Removed #753 because I found a bug in my implementation.

tomtinkerer commented 3 years ago

@nbatwara

Progress bars look great!

Results Table, for "Stream Biodiversity" and "Aquatic Health" the English and Metric columns should have values of 5 (instead of 50), and change the units to "pts" (same as Land Biodiversity and Game Wildlife). image

nbatwara commented 3 years ago

Added #753

tomtinkerer commented 3 years ago

Hey @nbatwara, good job on the bubble graphic. Still some things though, see below:

Change the "tons / yr" for Aquatic Health to "pts / yr". Get rid of "Mg / yr". (This metric is like Game Wildlife and Land/Stream Biodiversity scores, just a point system.) image

Updates to the Spider diagram were somehow. Please restore. image

Otherwise looks great!

nbatwara commented 3 years ago

@tomtinkerer hey Robert, #757 has a comment saying you handled the updates to the spider diagram which is why I got confused and didn't add them. Are you going to be pushing those with your 756 changes?

tomtinkerer commented 3 years ago

@nbatwara Apologies that's old intel, I thought we'd discussed that you'd do it (and it was in your last branch iteration, I believe?). Could you please add it back to this branch/PR

nbatwara commented 3 years ago

Oh some how I got confused and thought we were talking about me doing the bubble graphic instead of you (#753), sorry about that! I'll go ahead and work on it.

tomtinkerer commented 3 years ago

@nbatwara Thanks! Should be a very quick implementation, the code on that one isn't bad

nbatwara commented 3 years ago

@tomtinkerer done - you can test now.