LEW21 / pydbus

Pythonic DBus library
GNU Lesser General Public License v2.1
331 stars 75 forks source link

Refactor tests runner script to use dbus-launch instead of dbus-daemon #38

Closed acaso closed 7 years ago

acaso commented 7 years ago

This PR refactors tests/run.sh to use dbus-launch instead of dbus-daemon.

dbus-launch is more suited to this task and leads to a cleaner script. Also for some reason descriptor 0 redirection to a file was not working on some systems that I have tested it on.

I know there is an ongoing effort to migrate to pytest but this fixes run.sh in the meantime.

Considering that at this moment the tests are independent from each other, dbus-run-session could be used instead to have each test launch its own dbus session (and to get it finished automatically at the end of the test), but I have kept the original approach of a common dbus session for all the tests.