LFDT-Lockness / cggmp21

State-of-art threshold ECDSA in Rust
Apache License 2.0
55 stars 10 forks source link

Missing inputs to Fiat-Shamir hash (in non_threshold) #36

Closed maurges closed 1 year ago

maurges commented 1 year ago

In line 200 of non_threshold.rs, both X_i and sch_commit should be included in the hash.

Of course, line 222 also needs to be fixed so verification works

X_i is included, it's just called Xs (for the fact that it's many exes)

Moved from https://github.com/dfns-labs/paillier-zk/issues/28

maurges commented 1 year ago

sch_commits are also included as As. I can't find B_i though

maurges commented 1 year ago

Oh crap, it's completely gone with the schnorr proof as well

maurges commented 1 year ago

Right, it's for el-gamal keys which we don't have. Ok