Impl arithmetics for `NonZero<SecretScalar>`

LFDT-Lockness / generic-ec

Generic elliptic curve cryptography in Rust

Apache License 2.0

2 stars 2 forks source link

Impl arithmetics for `NonZero<SecretScalar>` #20

Closed survived closed 8 months ago

survived commented 8 months ago

@maurges I found a few arith trait not implemented, added them too in c0ec6d016f95db5844fd4df96399c73b98ea15a0 and 583aa5f28a871f93d0a648a2af5277de14fe07cb

survived commented 8 months ago

583aa5f28a871f93d0a648a2af5277de14fe07cb shows how easy it's to make an error! I was lucky clippy noticed that.

maurges commented 8 months ago

Also for the future, to reduce a chance of errors, we could add tests that fuzz some algebraic properties

survived commented 8 months ago

There are some tests here, but they aren't comprehensive. We should do more.