search

LFDT-Lockness / paillier-zk

Zero-knoledge proofs of some paillier cryptosystem properties for use in CGGMP21
Apache License 2.0
1 stars 1 forks source link

Fixes for review in #2 #3

Closed maurges closed 1 year ago

maurges commented 1 year ago

Our review process got a bit weird, so these are the fixes for comments in another PR.

Here I don't address the proposed API change and the problem with +-q <=> 2q

maurges commented 1 year ago

Use generic_ec instead of generic_ec_core

generic_ec_core is still used for custom curve definition. Can we add a small curve to generic-ec to remove this here?

survived commented 1 year ago

That's a small project I want to take after cggmp is done. Basically, we need to figure out parameters for this curve, and implement arithmetic operations.

maurges commented 1 year ago

salt any information into the challenge

I completely missed that when reading your last review. I'll do it in the next PR as to not make this one too big

survived commented 1 year ago

Ops, didn't see that comment:

Here I don't address the proposed API change and the problem with +-q <=> 2q

PR is good to merge!

survived commented 1 year ago

Btw shall we add CI here?

maurges commented 1 year ago

Btw shall we add CI here?

Absolutely. Let me try my hand at it