search

LGBT-CN / LGBTQIA-In-China

🏳️‍🌈 中国的性少数群体一直渴望着自由平等
744 stars 163 forks source link

疑似签名人数与显示人数不匹配？ #331

Closed Lafcadia closed 6 months ago

Lafcadia commented 6 months ago

“实际人数”（签名区行数）为206 (37-242)，但是README.md上显示有229人签署？owo? image

KevinZonda commented 6 months ago

Good question!

gxres042 commented 6 months ago

我有一个猜想。近期有一些更名的 PR，而 Action 很有可能将它们当作了新署名的 PR。所以这些更名的 PR 合并后会继续向上叠人数hh

KevinZonda commented 6 months ago

我有一个猜想。近期有一些更名的 PR，而 Action 很有可能将它们当作了新署名的 PR。所以这些更名的 PR 合并后会继续向上叠人数hh

Nah, 代码是统计 \n 而不是根据commit的

KevinZonda commented 6 months ago

I will rewrite the counting procedure. :)

KevinZonda commented 6 months ago

Hi I fixed the problem. The issue is caused by incorrect end tag <!-- 结束LGBT-CN 签名 -->, proper one should be like <!-- END LGBT-CN SIGNATURE -->. I rewrite the counter a little bit. Make it more robust. When such happened again, the counter application will panic so we can get when such situation happened again.