LGSInnovations / jupyter-sigplot

Jupyter Notebook extension for SigPlot.js
https://sigplot.lgsinnovations.com
Apache License 2.0
3 stars 9 forks source link

`plot.change_settings()` does not appear to modify the plot #37

Closed mrecachinas closed 5 years ago

sterre commented 5 years ago

@ddw saw this in the example Jupyter notebook. The example there was plot.change_settings(noxaxis=False, noyaxis=False, xi=True)

When he traced this down, he found:

Independent of fixing the example notebook, we may want to unify some of the plot_init and change_settings logic a bit more to address this.

mrecachinas commented 5 years ago

The specific issues addressed here are fixed as best Jupyter-Sigplot is concerned, but we still have #36.

Independent of fixing the example notebook, we may want to unify some of the plot_init and change_settings logic a bit more to address this.

If you are referring to noxaxis in plot init vs show_x_axis in change settings, that is perhaps better suited as an issue on sigplot itself. It appears at least the noxaxis and noyaxis have been fixed (see the example notebook).