LGSInnovations / jupyter-sigplot

Jupyter Notebook extension for SigPlot.js
https://sigplot.lgsinnovations.com
Apache License 2.0
3 stars 9 forks source link

Version 0.1.1 of the extension does not import because it references removed example module #5

Closed sterre closed 6 years ago

sterre commented 6 years ago

There's still an import from the removed example module in __init__.py that prevents successful import of jupyter_sigplot at version 0.1.1:

https://github.com/LGSInnovations/jupyter-sigplot/blob/f0580d4539f7ce778a1ff2e725dc49d4aac9c200/jupyter_sigplot/__init__.py#L5

Removing this line allows successful import and instantiation of a widget.

It seems likely that testing was done in a clone that still had the removed module in place, suggesting an opportunity for automated testing.

mrecachinas commented 6 years ago

Good catch. Thanks @sterre!

mrecachinas commented 6 years ago

Will setup Travis-CI and push to pip after. Hope to get that tonight or tomorrow.