search

LGSInnovations / react-sigplot

React wrapper for SigPlot.js
https://sigplot.lgsinnovations.com
Apache License 2.0
4 stars 10 forks source link

Typescript definitions #13

Open schoolboyqueue opened 5 years ago

mrecachinas commented 5 years ago

Hi @schoolboyqueue, just to make sure, you're asking for Typescript definitions to be added to React-SigPlot?

I will try to get around to that. One issue is this might require SigPlot.js to have Typescript definitions too.

schoolboyqueue commented 5 years ago

Yes, I believe it would be greatly beneficial to have typescript definitions for SigPlot.js as a baseline which would make it easier to have them for this project.

Side note: There exists a GitHub project that has attempted to do this already but their definitions are out of date. https://github.com/geontech/sigplot-ts

I use this library in projects at work (because its awesome) and our entire baseline is written in typescript.

maihde commented 5 years ago

I’m supportive of moving Typescript definitions into the main code base so they can stay updated.

Michael

On Sat, Jun 8, 2019 at 11:57 AM Jeremy Carter notifications@github.com wrote:

Yes, I believe it would be greatly beneficial to have typescript definitions for SigPlot.js as a baseline which would make it easier to have them for this project.

Side note: There exists a GitHub project that has attempted to do this already but their definitions are out of date. https://github.com/geontech/sigplot-ts

I use this library in projects at work (because its awesome) and our entire baseline is written in typescript.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/LGSInnovations/react-sigplot/issues/13?email_source=notifications&email_token=AABYEIXGE2WPNZLWC7PUUA3PZPJG7A5CNFSM4HRIRFNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXHXJJY#issuecomment-500135079, or mute the thread https://github.com/notifications/unsubscribe-auth/AABYEIUQZDXPKO5HH5HGT3DPZPJG7ANCNFSM4HRIRFNA .

mrecachinas commented 5 years ago

@schoolboyqueue Sounds good. I’ll start to work on this tomorrow.

@maihde We should discuss the SigPlot.js ts definitions.