LGUG2Z / komorebi-application-specific-configuration

A central place to document all tweaks required for Komorebi to 'just work' with as many applications as possible
MIT License
65 stars 51 forks source link

mpv doesn't tile/stays floating (on purpose?) #38

Closed Carl-Robert closed 1 year ago

Carl-Robert commented 1 year ago

I saw mpv is already added to the application specific configuration (actually it seems the PR adding mpv and mpv.net is partly reverted, because I see no mpv in my applications.yaml), so not sure if others deem this as the right way to handle it. For me I'd very much prefer it to be tiled normally.

If it is done on purpose, I petition to revert that.

Carl-Robert commented 1 year ago

Testing locally (I don't really have any idea what I'm doing):

Adding the old mpv PR doesn't work. Using the mpv.net rule for mpv does work! However it has some delay before it gets picked up (have to resize the mpv window or minimize and restore it). This could partly be due to my mpv configuration.

If anyone has a better suggestion than using the mpv.net rule feel free to butt in. I'll make a PR for this using the mpv.net rule meanwhile...

40

sitiom commented 1 year ago

The mpv and mpv.net rules work for me. Did you try testing it first without a config? If you have a borderless config, we can't add a rule for that as Windows like those are a trouble to manage, and it's non-default behavior anyway, so that should be up to the user to add via the overrides.yaml.

Carl-Robert commented 1 year ago

With mpv --no-config it seems to be managed just fine. I don't have any UI tweaks enabled, so didn't realize to check that. It seems starting with fullscreen breaks komorebi, since only using mpv --no-config -fs breaks tiling. The mpv window starts maximized, but exiting fullscreen keeps it floating and it refuses to tile afterwards.

I didn't realize overrides.yaml was a thing, so this clearly belongs in there then. Unless want to have a rule for this relatively common option (starting fullscreen) applied by default.