search

LGUG2Z / komorebi-application-specific-configuration

A central place to document all tweaks required for Komorebi to 'just work' with as many applications as possible
MIT License
69 stars 53 forks source link

feat(apps): add MuseScore #74

Closed cubeDHS2017 closed 11 months ago

cubeDHS2017 commented 11 months ago

I added a rule for MuseScore that would overflow it's borders.

sitiom commented 11 months ago

Your commit history seems to be dirty. I recommend cleaning up your master branch and creating your PRs on a separate branch to avoid unexpected changes being introduced to your PR. See: GitHub Flow

cubeDHS2017 commented 11 months ago

Your commit history seems to be dirty. I recommend cleaning up your master branch and creating your PRs on a separate branch to avoid unexpected changes being introduced to your PR. See: GitHub Flow

How would I better setup my workflow for this project and making PRs?

sitiom commented 11 months ago
  1. Delete and recreate your fork to clean up your master branch (or clean it up with a bunch of commands if you know how 🙂)
  2. From the master branch, create a new branch based on the new app you want to add (Example: musescore) image
  3. Make your changes from there, run komorebic fmt-asc applications.yaml, and open a PR based on that branch.
  4. Once your PR is merged, delete the branch, go back to the master branch, and sync the upstream changes from your fork.

I recommend learning the basics of Git to get started: https://docs.github.com/en/get-started/quickstart/git-and-github-learning-resources