search

LGUG2Z / komorebi

A tiling window manager for Windows 🍉
https://lgug2z.github.io/komorebi/
Other
9.63k stars 200 forks source link

feat: adds the ahk flag to the stop command #1043

Closed Doomwhite closed 1 month ago

Doomwhite commented 1 month ago

Thought it would make sense to add the ahk flag to the stop command, cuz it exists in the start and enable-autostart commands...

I tried to replicate the new command using the others as a base... Is PowerShell version compatibility something you would like me to ensure? Should I focus on supporting older versions (like PowerShell 5.1 or even earlier), or is it ok to target more modern versions (PowerShell Core 6+)?

Let me know so I can adjust the script...

LGUG2Z commented 1 month ago

Thanks for doing this!

Is PowerShell version compatibility something you would like me to ensure? Should I focus on supporting older versions (like PowerShell 5.1 or even earlier)

We definitely want to ensure compatibility with the earliest versions possible as there is no PS version requirement for using komorebi and it's likely many people will use whatever the "old" version is that comes installed with Windows.

LGUG2Z commented 1 month ago

There is also a relevant approach mentioned in this issue you may want to consider: https://github.com/LGUG2Z/komorebi/issues/951#issuecomment-2404090608

Doomwhite commented 1 month ago

There is also a relevant approach mentioned in this issue you may want to consider: #951 (comment)

Yeah, I was wondering about check even the executable name, but got worried about someone using AutoHotkey executable renamed :P. But it's fine...

Doomwhite commented 1 month ago

There is also a relevant approach mentioned in this issue you may want to consider: #951 (comment)

I couldn't make use of that script, ~maybe it's a skill issue,~ but I made the script check the executable name.

LGUG2Z commented 1 month ago

My apologies, you'll need to git rebase master as I did an interactive rebase to remove a commit from the history.

Doomwhite commented 1 month ago

My apologies, you'll need to git rebase master as I did an interactive rebase to remove a commit from the history.

Ok, I've squashed the commits.