search

LGUG2Z / komorebi

A tiling window manager for Windows 🍉
https://lgug2z.github.io/komorebi/
Other
9.64k stars 200 forks source link

[BUG]: 0.1.19 ahk generated library requires whkd arg for Stop command #578

Closed BlueDrink9 closed 1 year ago

BlueDrink9 commented 1 year ago

Describe the bug Title should explain enough. Presumably ahk users shouldn't care about whkd.

Introduced by f4e0fb9

To Reproduce Update komorebi and regenerate ahk lib

Expected behavior Stop takes no arg (or maybe has an ahk default arg)

LGUG2Z commented 1 year ago

The AHK library functions are autogenerated with the AhkFunction proc macro from the structs used to define which arguments commands can take.

If someone really wants to pick this up (or if they really love writing proc macros), they can add support for AHK optional arguments with defaults in the output generated by derive-ahk. I'm probably not gonna work on this though because this is honestly my least favourite part of the entire codebase/repo.

Given how difficult proc-macros are to work with, I'm also open to accepting "hacks" run on the post-proc-macro output (ie. immediately before the bytes are written) that can add defaults in this and other cases where it is appropriate.

LGUG2Z commented 1 year ago

Figured it was best to do the hackery myself ;) This should be fixed now on master

BlueDrink9 commented 1 year ago

While I'm here, was the 0.19 komorebic exe in the releases compiled at optimised level? I'm having massive performance issues with it. Using a terminal to send the commands, it takes almost a second to respond and change focus. If I replace it with the 0.18 exe I have no issues.

nascentt commented 1 year ago

While I'm here, was the 0.19 komorebic exe in the releases compiled at optimised level? I'm having massive performance issues with it. Using a terminal to send the commands, it takes almost a second to respond and change focus. If I replace it with the 0.18 exe I have no issues.

You might want to split off a separate issue for thay