LGUG2Z / komorebi

A tiling window manager for Windows 🍉
https://lgug2z.github.io/komorebi/
Other
9.64k stars 200 forks source link

[BUG]: Rainmeter widgets always on top #679

Closed Zerogaku closed 8 months ago

Zerogaku commented 9 months ago

Describe the bug This might be an unintended side effect of how floating windows are treated (as in always placed at the top), so when tiling with komorebi, rainmeter is always overlaying applications, i've tried changing rainmeter's position settings but to no avail, it will only be displayed normally in the background when pausing or stopping komorebi. "ignoring" rainmeter with float rules doesn't work how I would like it, and I can't seem to find a rule that "moves application behind every other window".

To Reproduce Steps to reproduce the behavior:

Expected behavior Rainmeter should stay behind any open windows (if "on desktop" or "bottom" position is set for the widgets)

Screenshots and Videos komorebi on: image image

komorebi off: image

Operating System Provide the output of systeminfo | grep "^OS Name\|^OS Version"

For example:

OS Name:                   Microsoft Windows 11 Home
OS Version:                23H2 Build 22631.3155

komorebic check Output Provide the output of komorebic check

No KOMOREBI_CONFIG_HOME detected, defaulting to C:\Users\Null

Looking for configuration files in C:\Users\Null

Found komorebi.json; this file can be passed to the start command with the --config flag

Found C:\Users\Null\.config\whkdrc; key bindings will be loaded from here when whkd is started, and you can start it automatically using the --whkd flag

If running 'komorebic start --await-configuration', you will manually have to call the following command to begin tiling: komorebic complete-configuration

Additional context Add any other context about the problem here.

In particular, if you have any other AHK scripts or software running that handle any aspect of window management or manipulation

I am using autohotkey version 2 for keybindings (for focusing, opening, closing windows, changing layouts, etc)

#SingleInstance Force

; Load library
#Include komorebic.lib.ahk

Capslock::Esc
Esc::Capslock
^!Space Up::Send "{Control Up}{Alt Up}{LWin}"
~LWin::Send "{Blind}{vkE8}"

;#Tab::
;{   
;  Send "{LAlt Down}{Tab}"          
;  KeyWait "LWin"  ; Wait to release left Win key
;  Send "{LAlt Up}" ; Close switcher on hotkey release
;}
#Tab::FocusLastWorkspace()

; Focus windows
; #h::Focus("left")
; #j::Focus("down")
; #k::Focus("up")
; #l::Focus("right")
#k::CycleFocus("previous")
#j::CycleFocus("next")

; Move windows
#+h::Move("left")
#+j::Move("down")
#+k::Move("up")
#+l::Move("right")
#Space::Promote()

; Stack windows
#Left::Stack("left")
#Right::Stack("right")
#Up::Stack("up")
#Down::Stack("down")
#;::Unstack()
#[::CycleStack("previous")
#]::CycleStack("next")

; Resize
#+=::ResizeAxis("vertical", "increase")
#+-::ResizeAxis("vertical", "decrease")
#=::ResizeAxis("horizontal", "increase")
#-::ResizeAxis("horizontal", "decrease")

; Manipulate windows
#+Space::ToggleFloat()
#q::WinClose(WinGetTitle("A"))

; Window manager options
#+r::Retile()
#!p::TogglePause()
#m::ToggleMaximize()

; Layouts
;!x::FlipLayout("horizontal")
;!y::FlipLayout("vertical")
#PgDn::CycleLayout("next")
#PgUp::CycleLayout("previous")

#+u::ToggleMonocle()
#y::ChangeLayout("bsp")
#+t::ChangeLayout("horizontal-stack")
#t::ChangeLayout("vertical-stack")

; Workspaces
#1::FocusWorkspace(0)
#2::FocusWorkspace(1)
#3::FocusWorkspace(2)
#4::FocusWorkspace(3)
#5::FocusWorkspace(4)
#6::FocusWorkspace(5)
#7::FocusWorkspace(6)
#8::FocusWorkspace(7)
#9::FocusWorkspace(8)
#0::FocusWorkspace(9)

; Move windows across workspaces
#+1::MoveToWorkspace(0)
#+2::MoveToWorkspace(1)
#+3::MoveToWorkspace(2)
#+4::MoveToWorkspace(3)
#+5::MoveToWorkspace(4)
#+6::MoveToWorkspace(5)
#+7::MoveToWorkspace(6)
#+8::MoveToWorkspace(7)
#+9::MoveToWorkspace(8)
#+0::MoveToWorkspace(9)

#Enter::Run "C:\Users\Null\AppData\Local\Microsoft\WindowsApps\wt.exe"
#w:: Run "C:\ProgramData\Microsoft\Windows\Start Menu\Programs\Firefox.lnk"
#r:: Run "explorer.exe"
azinsharaf commented 9 months ago

i was able to preproduce this. win 10 pro, rainmeter 4.4.18.3727, komorebi 0.1.21

Zerogaku commented 9 months ago

might be related to https://github.com/LGUG2Z/komorebi/issues/236

Looki2000 commented 8 months ago

it's a very annoying bug to me too. I hope it will be fixed.

LGUG2Z commented 8 months ago

I'm probably not going to look into personally this since I don't use Rainmeter, but I think this is a great first issue for anyone who is really bothered by it. You can start by playing around with the various flags here: https://github.com/LGUG2Z/komorebi/blob/master/komorebi/src/windows_api.rs#L360

Zerogaku commented 8 months ago

Issue appears to have been fixed in 0f6d1a465c840ea1c095966b0fdf8af574e10fc4