LGUG2Z / komorebi

A tiling window manager for Windows 🍉
https://lgug2z.github.io/komorebi/
Other
9.64k stars 200 forks source link

[BUG]: Dragging floating windows also moves tiled window underneath #733

Closed jpmiller25 closed 7 months ago

jpmiller25 commented 7 months ago

When I move a floating window from one monitor to another, the tiled window underneath also follows.

To Reproduce Steps to reproduce the behavior: 2-monitor setup Open tiled window on monitor A, e.g. browser. Open floating window on monitor A, e.g. calculator. Drag calculator from A to B and drop. Browser gets moved from A to B.

Expected behavior Tiled windows stay where they are, tiled windows can be moved freely on top.

Operating System

OS Name:                   Microsoft Windows 10 Business
OS Version:                10.0.19045 N/A Build 19045

komorebic check Output

KOMOREBI_CONFIG_HOME detected: C:\Users\jmiller\.config\komorebi

Looking for configuration files in C:\Users\jmiller\.config\komorebi

Found komorebi.json; this file can be passed to the start command with the --config flag

Found C:\Users\jmiller\.config\whkdrc; key bindings will be loaded from here when whkd is started, and you can start it automatically using the --whkd flag
LGUG2Z commented 7 months ago

This also annoys the hell out of me when I run into it 😅

I'll try to look at this for v0.1.24.

azinsharaf commented 7 months ago

i have seen this even on one monitor. if MS Teams is float and i move it with the mouse it retiles the windows behind it.

LGUG2Z commented 7 months ago

We probably need to update this check to also ensure that we only trigger this code path when the window that triggers the event is known to the workspace: https://github.com/LGUG2Z/komorebi/blob/master/komorebi/src/process_event.rs#L342

jpmiller25 commented 7 months ago

Works great thank you!!!