LGhassen / Deferred

Add deferred rendering to KSP
Other
72 stars 2 forks source link

Dark side of moons/planets is not (completely) dark #19

Closed Zeldrine closed 3 months ago

Zeldrine commented 3 months ago

Hey (thanks for the amazing work):

After installing Deffered Lightning, I had this bug appear where dark side of planets and moons terrains would not be completely dark anymore (see pictures). I have the impression that there is a "distance" between the craft and the body where some lightning effect would apply because the area is bigger when the altitude is lower (Duna : small surface of terrain being lit / Mun : larger area). Related to that, the craft will always be visible, even in pitch black.

When installing DL, I also had to manually update Kopernicus, Textures Unlimited and Parallax so I'm also looking there also I find it less likely the problem is coming from there.

Any ideas? Best regards

KSP.log

KSP DL Bug - Eve KSP DL Bug - Duna KSP DL Bug - Mun KSP DL bug - Eeloo

LGhassen commented 3 months ago

This was always the case, there is always a faint ambient for gameplay reasons.

LGhassen commented 3 months ago

Closed because this is a stock feature and nothing changed there, for gameplay reasons. Feel free to reopen if you have side by sideo comparisons of the lighting actually changing with deferred.

Zeldrine commented 3 months ago

Hi again (thank you for your quick response),

Ok so my apologies, you were right about the fact that it's not supposed to be pitch black.

However there is still a problem: The pitch black that's outside the visible terrain. This is mostly visible on the 2nd screenshot, where only a small part of the body's terrain is visible, But it's also visible on 3rd and 4th screenshots, where the pitch black part is visible on the edge of the visible terrain.

I made a comparaison without DL :

Duna without DL : KSP DL NoBug - Duna

Duna with DL : KSP DL Bug - Duna

Mun without DL : KSP DL NoBug - Mun

Mun with DL : KSP DL Bug - Mun

Thank you for your help :) !