Closed Clayell closed 4 months ago
Clayell
commented
4 months ago Additional bug, the flight scene in the atmosphere shows strange black blobs of terrain, with seems to slightly correlate with the cloud position? Not sure. (using normal EVE clouds, not volumetric) The bug goes away when in the space flight scene.
Clayell
commented
4 months ago Additional bug, the flight scene in the atmosphere shows strange black blobs of terrain, with seems to slightly correlate with the cloud position? Not sure. (using normal EVE clouds, not volumetric) The bug goes away when in the space flight scene.
This bug seems to be active or inactive depending on the tufx profile I use, I'll have to test which specific setting removes the bug.
Clayell
commented
4 months ago This bug seems to be active or inactive depending on the tufx profile I use, I'll have to test which specific setting removes the bug.
Alright, so the black blobs directly correspond to the cloud position, and they also appear in the tracking station view. Additionally, it is definitely HDR that triggers this bug. When HDR is on, the bug appears, but when HDR is off, the bug vanishes. In the following pictures I have only changed the HDR setting.
LGhassen
commented
4 months ago @Clayell for the black cloud artifacts, this can be fixed by setting the _ShadowFactor value in the cloud config "EarthCloudsLow" to 0.75 or any other value below 1 (default is 3), can you confirm this works? This seems to be independent from deferred btw and just related to hdr and cloud shadows.
I'm looking into the other issues.
Clayell
commented
4 months ago cloud config "EarthCloudsLow"
Where do I find this config?
LGhassen
commented
4 months ago In the EVE UI
LGhassen
commented
4 months ago I'll list procedurail fairings as incompatible and handle it separately. The other issues will be fixed in the next version apart from the shadows in the editor which is a stock issue I won't look into now.
Clayell
commented
4 months ago @Clayell for the black cloud artifacts, this can be fixed by setting the _ShadowFactor value in the cloud config "EarthCloudsLow" to 0.75 or any other value below 1 (default is 3), can you confirm this works? This seems to be independent from deferred btw and just related to hdr and cloud shadows.
Yep, can confirm that setting the value below 1 removes the black cloud artifacts, thanks! Perhaps some sort of check should be put in place with EVE and/or TUFX to turn that value down if HDR is enabled?
LGhassen
commented
4 months ago I will just cap the end result to be between 0-1
LGhassen
commented
4 months ago The other issues should be fixed now in yesterday's version, apart from the shadows in the editor, and the hdr cloud shadow issue which will be fixed separately in the next EVE/Scatterer update. Feel free to reopen this if you see any issues.
Clayell
commented
4 months ago The terrain fails to load in the editor scene. ... The terrain is very shiny in the flight scene. (seems fine in the KSC scene as far as I can tell)
Confirmed fixed.
Clayell
commented
4 months ago Edit: For the below pictures I had dithered transparency on, but it seems like dithered transparency doesn't affect the result at all?
Interestingly, the transparency stuff seems to depend on the TUFX profile. Using Default-Editor/Empty gives the normal white opaque stuff, but using Default-MainMenu/KSC/Tracking/Flight fixes the bug entirely. Looking into the TUFX settings, it seems to be another bug entirely controlled by HDR. (where turning HDR on fixes it) Might be worth looking into.
Default-Editor
Default-Editor with HDR on
(although it seems that the transparency in the fairing only shows radially attached parts? might be a stock bug idk)
Clayell
commented
4 months ago @LGhassen I think you force-closed this issue or something, I can't re-open it.
Additionally, al2me6 notes: (in regards to the TUFX HDR procedural fairings thing)
I'll take a look at exactly what PF is doing tonight. ... something is still messed up. If it's actually semitransparent then something is getting rendered in forward.
LGhassen
commented
4 months ago Not RSS related, I listed procedural fairings as incompatible in the compat list
Clayell
commented
4 months ago Not RSS related, I listed procedural fairings as incompatible in the compat list
Yes, but I think you should mention that turning HDR on removes the "white fairing" issue with procedural fairings.
The terrain fails to load in the editor scene.
Something strange happens with the shadow details when moving the camera around in the editor.
The terrain is very shiny in the flight scene. (seems fine in the KSC scene as far as I can tell)
Procedural Fairings turn white when the mouse is hovered near them, instead of the expected translucent. (this is probably the noted transparency issue) https://youtu.be/BGDT3lRFajA
KSP.log: https://drive.google.com/file/d/1bwIq-_UrPBlHx9xJ1oz3WuBvVBFn5qdO/view?usp=sharing
Installed mods:
I would like to note that using deferred lighting instead of planetshine on RSS planets seems to work fine.