KSP 1.10.0 - Karman Line now sharply visible when close to it.

[jmigreen]

Since the update, while Scatterer still works very well overall, there are a couple notable exceptions. One of them is that the atmospheric edges of all worlds "karman line" is visible where as beforehand the atmosphere smoothly faded into space. It looks as if the atmosphere just sharply ends.

Screenshot attached of current state:

Screenshot of before:

[LGhassen]

For the atmosphere I made a temporary fix here, for testing before I fix any other issues and making a full release: https://forum.kerbalspaceprogram.com/index.php?/topic/103963-wip18x-19x-scatterer-atmospheric-scattering-v00610-25042020/&do=findComment&comment=3813263

[jmigreen]

Hi, thank you so much for the fast response. I know you've got a life outside of KSP.

I have tested the new DLL, and can report the following:

1. It shows moderate improvement on Kerbin. The Karman line is much less visible.

2. Unfortunately, it seems this is limited to Kerbin, as Duna and Laythe still show the line pretty noticeably (although I looked at older screenshots and it appears that it was always more visible there, so that may not be new.

3. Unfortunately, the fix has created a new issue: Kerbin at night is completely black. No ambient light.

Kind Regards

[LGhassen]

That has always been this way and is a different issue I'm well aware of.

What changed with 1.10 and what my above .dll fixes is that the stock atmosphere was no longer getting disabled, so you were getting stock sky on top of scatterer sky.

[jmigreen]

Understood.  I think we can close this issue then.  Should I open a separate one about the new .dll causing a loss of ambient lighting at night (at least on Kerbin), or are you already tracking that one?  From: LGhassenSent: Wednesday, July 15, 2020 2:27 PMTo: LGhassen/ScattererCc: jmigreen; AuthorSubject: Re: [LGhassen/Scatterer] KSP 1.10.0 - Karman Line now sharply visible when close to it. (#102) That has always been this way and is a different issue I'm well aware of.What changed with 1.10 and what my above .dll fixes is that the stock atmosphere was no longer getting disabled, so you were getting stock sky on top of scatterer sky.—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or unsubscribe. 

[LGhassen]

Which loss of ambient light?

[jmigreen]

I can do testing in more places if needed, but on Kerbin at night, there appears to be complete darkness. This goes away if I revert to the previous version of the .dll

[LGhassen]

@jmigreen I'm unable to reproduce your complete darkness issue. Everything is working correctly here, I can still see at night.

[jmigreen]

Ok, I will re-test and see if I can still reproduce in 1.10.1 and under what circumstances.

[jmigreen]

I can reproduce, but it is intermittent: The game will load fine, and after continued play this will eventually happen. Perhaps a memory leak then? It's not just kerbin at night, it's an ambient lighting issue. Only direct light is visible. Anything not directly illuminated is completely black. Attaching new screenshots.

Prior to the issue occurring, ambient lighting is ok even with the new DLL. Reverting to the old DLL prevents the issue. It never occurs.

[LGhassen]

Can you try to disable the option "disable scaled space ambient lighting" and play like that for a while to see if it eliminates the issue?

[jmigreen]

Sure, I've made that change and will report back when I get a chance to do some testing later in the week.

[LGhassen]

@jmigreen can you try scatterer 0.0630? Someone on the forum reported it fixed this issue.

[jmigreen]

@LGhassen Tested with that setting change and it did indeed fix the issue. Will try the new version as well. Sorry for the delay.

[LGhassen]

Closing this since it is fixed