search

LGhassen / Scatterer

Atmospheric scattering mod for KSP
Other
184 stars 51 forks source link

TAA broken with TUFX #157

Open LGhassen opened 2 years ago

LGhassen commented 2 years ago

https://forum.kerbalspaceprogram.com/index.php?/topic/103963-wip19x-112x-scatterer-atmospheric-scattering-00831-01022022-scattering-improvements-in-game-atmo-generation-and-multi-sun-support/&do=findComment&comment=4104674

LGhassen commented 2 years ago

Fix in 0.0834

LGhassen commented 2 years ago

Reportedly still broken in map view

JonnyOThan commented 2 years ago

I'm not quite understanding the bug that was reported here. If AA is disabled in TUFX, does it still affect scatterer? Because I'm pretty sure the reverse IS true: if TAA is disabled in scatterer, it disables TUFX's antialiasing setting.

I prefer TUFX for TAA for 2 reasons: it looks better than scatterer's version and it doesn't jitter the UI. But the problem is that it seems to be disabled every time I switch back from map mode if I disable TAA in scatterer.

Is TAA actually an important part of how scatterer works, or is it just supposed to improve the graphics quality? If the latter, would it be crazy to remove it and just recommend using TUFX instead? If scatterer can't work with any other kind of AA then it could always forcibly disable them when detected or pop up warnings or whatever.

Here's some comparison shots (no AA, scatterer's TAA, and TUFX's TAA): aa_none aa_scat_taa aa_tufx_taa

LGhassen commented 2 years ago

"Reportedly still broken in map view", it's broken with scatterer regardless of scatterer having TAA or not, it's that simple.

JonnyOThan commented 2 years ago

Huh, someone pointed out to me that TUFX’s problem with persisting AA settings is a known issue and not related to scatterer. I was pretty sure I tested without scatterer installed at all but I must have missed something. Sorry about that :(