search

LGouellec / kafka-streams-dotnet

.NET Stream Processing Library for Apache Kafka 🚀
https://lgouellec.github.io/kafka-streams-dotnet/
MIT License
453 stars 73 forks source link

add support for stream record timestamp extractor #255

Closed ppilev closed 1 year ago

ppilev commented 1 year ago

Added IKStream<K, V>.WithRecordTimestamp allows stream record timestamp to be extracted from K, V values

LGouellec commented 1 year ago

Hi @ppilev,

Can you add unit tests please ?

Kr

ppilev commented 1 year ago

hi @LGouellec, sorry for being late with the unit tests. please check now.

regards,

LGouellec commented 1 year ago

Hi @ppilev,

In addition, can you change the visibility to this method at Public

https://github.com/LGouellec/kafka-streams-dotnet/blob/ee2ada76ad7fec25a9a451615c650e5c6dd0940c/core/ProcessorContext.cs#L105

Thanks,

ppilev commented 1 year ago

hi @LGouellec, updated my branch with latest changes from develop and that method is changed to be pubic now

regards,

LGouellec commented 1 year ago

Thanks @ppilev for your contribution.

ppilev commented 1 year ago

hi @LGouellec,

when we can expect a new version with these bits released?

regards,

LGouellec commented 1 year ago

Regarding the 1.5 milestone, we can hope begin of July