LHCfitNikhef / smefit_release

SMEFiT a Standard Model Effective Field Theory fitter
GNU General Public License v3.0
6 stars 1 forks source link

Single operator constrain with `single_parameter_fit` #65

Closed giacomomagni closed 7 months ago

giacomomagni commented 7 months ago

This PR is to allow single operator constrain in single parameter fits. #64

Before constrain where not allowed in the multiple single_parameter_fits.

codecov[bot] commented 7 months ago

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (06d1e3c) 42.29% compared to head (ce5314d) 41.88%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/LHCfitNikhef/smefit_release/pull/65/graphs/tree.svg?width=650&height=150&src=pr&token=MRTEXUP8XU&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LHCfitNikhef)](https://app.codecov.io/gh/LHCfitNikhef/smefit_release/pull/65?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LHCfitNikhef) ```diff @@ Coverage Diff @@ ## main #65 +/- ## ========================================== - Coverage 42.29% 41.88% -0.41% ========================================== Files 29 29 Lines 2355 2378 +23 ========================================== Hits 996 996 - Misses 1359 1382 +23 ``` | [Flag](https://app.codecov.io/gh/LHCfitNikhef/smefit_release/pull/65/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LHCfitNikhef) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/LHCfitNikhef/smefit_release/pull/65/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LHCfitNikhef) | `41.88% <0.00%> (-0.41%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LHCfitNikhef#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/LHCfitNikhef/smefit_release/pull/65?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LHCfitNikhef) | Coverage Δ | | |---|---|---| | [src/smefit/runner.py](https://app.codecov.io/gh/LHCfitNikhef/smefit_release/pull/65?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LHCfitNikhef#diff-c3JjL3NtZWZpdC9ydW5uZXIucHk=) | `38.84% <0.00%> (-7.71%)` | :arrow_down: |
giacomomagni commented 7 months ago

@ecelada I think this is the proper fix to the issue you raised some weeks ago. I'm not sure if you can review, but if you can it would be great. Thanks

ecelada commented 7 months ago

Thanks! I will review but it's probably better if someone else does it as well