search

LHeng1 / pe

0 stars 0 forks source link

Redundancy of Feature "Diagnose" #3

Open LHeng1 opened 11 months ago

LHeng1 commented 11 months ago

I understand having to differentiate between edit and diagnose command since diagnose specifically adds or edits the current illnesses, but perhaps it would be better to change the format of diagnose from:

diagnose INDEX illnesses=ILLNESS

to:

diagnose INDEX ILLNESS

since diagnose is already specific for illnesses.

nus-se-script commented 11 months ago

Team's Response

We did it for consistency with our other features. Every other command where we modify a field we will specify field=value.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]