search

LI3DS / api-li3ds

LI³DS Rest API
GNU General Public License v3.0
0 stars 3 forks source link

foreignpc issue with rosbag #39

Closed elemoine closed 7 years ago

elemoine commented 7 years ago

The code that creates the "schema" table doesn't work with the Rosbag FDW. This is because a topic option is required when creating a "schema" table from a rosbag:

create foreign table rosbag_pointcloud2_format (
    schema text
) server rosbagserver
    options (
        topic '/Laser/velodyne_points'
        , metadata 'true'
);

Not sure what's the best way to fix that.

ldgeo commented 7 years ago

What do you means by "it doesn't work", what's the error ? I think topic is not required : https://github.com/LI3DS/fdw-li3ds/blob/master/fdwli3ds/rosbag_.py#L81 neither in https://github.com/LI3DS/fdw-rosbag/blob/pcpoint/rosbagfdw/__init__.py#L226

mbredif commented 7 years ago

My bad, topic was facultative at first, but it should now be mandatory. The lines @ldgeo mentionned should be updated.

elemoine commented 7 years ago

I am currently fixing this.

elemoine commented 7 years ago

And there are other issues. https://github.com/LI3DS/fdw-li3ds/pull/19 is one of them.