LIFsCode / ELOC-3.0

Firmware for ELOC 3.0 Hardware
MIT License
2 stars 3 forks source link

Only count detected events #100

Open EDsteve opened 1 month ago

EDsteve commented 1 month ago

@OOHehir

  1. Right now, the csv table for detected events creates a new row for every inference (Somehow every row counts as a detected event in the app (getStatus), so the app now shows thousands of detected events). This should be changed to detected trumpets only. Let's set the value to 0.8 for now. This change should be enough for this new release. Just to avoid any bigger changes. Not too much time for testing any more. So let's keep it as simple as possible.

  2. For the future (after this release) it would be great to integrate these features: a. The threshold should be able to set in the app (via setConfig) b. Soon, the model will not only detect trumpets but other sounds as well. So it should be automatically extended to as many features the model brings with it. For example:

    • trumpets: 24
    • rumbles: 39
    • growls: 12

Do you have enough time to implement the first point within the next day? If not. No problem. If you have more ideas on how to improve. Let me know :)

OOHehir commented 1 month ago

@EDsteve Yes, 1 above should be fine. 2 would be do-able with a little bit of work.

OOHehir commented 1 month ago

@EDsteve It seems the latest model changed the label for non-target sounds from 'background' to 'others'. Theses labels are included in the imported EI model code.

I've expanded the labels for non-target sounds here. Sounds other than those listed below will be classified as a 'detected event' & the event recorded.

Note: The only outstanding issue here is to enable the detection threshold to be set via Bluetooth