search

LIFsCode / ELOC-3.0

Firmware for ELOC 3.0 Hardware
MIT License
2 stars 3 forks source link

Resolve differences between sdkconfig.esp32dev & sdkconfig.esp32dev-ei #45

Closed OOHehir closed 6 months ago

OOHehir commented 7 months ago

@LIFsCode There are some differences between the two version of sdkconfig. I think it would make more sense just to have one. I'm unsure of whats are required settings & what happens to be 'just different'.

Could you perhaps take a look & see whats needed from your code?

I've enabled PSRAM/SPIRAM & set the flash size to 16MB in both versions.

LIFsCode commented 7 months ago

@OOHehir I just had a look at the differences acutally all is requierd!

They affect:

  1. https://github.com/LIFsCode/ELOC-3.0/issues/26
  2. Firmware update & partition layout
OOHehir commented 7 months ago

@LIFsCode OK, will take a look, thanks

OOHehir commented 7 months ago

@LIFsCode @EDsteve I've just pushed a new commit that more closely aligns the non-EI & the EI build. I hope this won't cause any build issues for you both, please let me know if it does.

There doesn't appear to be a straightforward way of using the same sdkconfig file for both builds so looks like we'll just have to keep them manually identical. I considered using a 'linked' file but might cause cross-platform issues.

LIFsCode commented 6 months ago

I combined both sdkconfig files into a single .defaults file.

Here is a short explanation about the hierarchy of sdkconfig files. So it is still possible to add different sdkconfig options for esep32dev and esp32dev-ei build, but both now run from the same default config

OOHehir commented 6 months ago

@LIFsCode Further to this discussion I added a comment here to clarify the handling of these generated files.