LIHPC-Computational-Geometry / coupe

the concurrent partitioner
https://LIHPC-Computational-Geometry.github.io/coupe/
Apache License 2.0
12 stars 3 forks source link

cartesian/rcb: collect axis weights into a vec #268

Closed hhirtz closed 1 year ago

hhirtz commented 1 year ago

so that weighted_median works with O(sqrt(n)) weights instead of O(n). This should reduce memory accesses and speed up the overall execution.

base wt

codecov[bot] commented 1 year ago

Codecov Report

Base: 50.09% // Head: 50.08% // Decreases project coverage by -0.01% :warning:

Coverage data is based on head (56bbaf5) compared to base (49c06eb). Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #268 +/- ## ========================================== - Coverage 50.09% 50.08% -0.02% ========================================== Files 41 41 Lines 7474 7478 +4 ========================================== + Hits 3744 3745 +1 - Misses 3730 3733 +3 ``` | [Impacted Files](https://codecov.io/gh/LIHPC-Computational-Geometry/coupe/pull/268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LIHPC-Computational-Geometry) | Coverage Δ | | |---|---|---| | [src/cartesian/rcb.rs](https://codecov.io/gh/LIHPC-Computational-Geometry/coupe/pull/268/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LIHPC-Computational-Geometry#diff-c3JjL2NhcnRlc2lhbi9yY2IucnM=) | `0.00% <0.00%> (ø)` | | | [src/algorithms/vn/first.rs](https://codecov.io/gh/LIHPC-Computational-Geometry/coupe/pull/268/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LIHPC-Computational-Geometry#diff-c3JjL2FsZ29yaXRobXMvdm4vZmlyc3QucnM=) | `90.35% <0.00%> (+0.87%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LIHPC-Computational-Geometry). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LIHPC-Computational-Geometry)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.