LIHPC-Computational-Geometry / coupe

the concurrent partitioner
https://LIHPC-Computational-Geometry.github.io/coupe/
Apache License 2.0
12 stars 3 forks source link

cartesian: fix partition being transposed #286

Closed hhirtz closed 1 year ago

hhirtz commented 1 year ago

Since we start with coord=1, Grid::part_of must also be called with coord=1, otherwise the partition array ends up being transposed.

codecov[bot] commented 1 year ago

Codecov Report

Base: 49.99% // Head: 43.76% // Decreases project coverage by -6.22% :warning:

Coverage data is based on head (5c7dafe) compared to base (a8862c5). Patch coverage: 25.00% of modified lines in pull request are covered.

:exclamation: Current head 5c7dafe differs from pull request most recent head fb88706. Consider uploading reports for the commit fb88706 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #286 +/- ## ========================================== - Coverage 49.99% 43.76% -6.23% ========================================== Files 41 51 +10 Lines 7335 8685 +1350 ========================================== + Hits 3667 3801 +134 - Misses 3668 4884 +1216 ``` | [Impacted Files](https://codecov.io/gh/LIHPC-Computational-Geometry/coupe/pull/286?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LIHPC-Computational-Geometry) | Coverage Δ | | |---|---|---| | [tools/num-part/src/database/mod.rs](https://codecov.io/gh/LIHPC-Computational-Geometry/coupe/pull/286?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LIHPC-Computational-Geometry#diff-dG9vbHMvbnVtLXBhcnQvc3JjL2RhdGFiYXNlL21vZC5ycw==) | `0.00% <0.00%> (ø)` | | | [tools/src/lib.rs](https://codecov.io/gh/LIHPC-Computational-Geometry/coupe/pull/286?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LIHPC-Computational-Geometry#diff-dG9vbHMvc3JjL2xpYi5ycw==) | `0.18% <0.00%> (ø)` | | | [src/cartesian/mod.rs](https://codecov.io/gh/LIHPC-Computational-Geometry/coupe/pull/286?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LIHPC-Computational-Geometry#diff-c3JjL2NhcnRlc2lhbi9tb2QucnM=) | `85.06% <50.00%> (ø)` | | | [tools/src/bin/mesh-dup.rs](https://codecov.io/gh/LIHPC-Computational-Geometry/coupe/pull/286?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LIHPC-Computational-Geometry#diff-dG9vbHMvc3JjL2Jpbi9tZXNoLWR1cC5ycw==) | `3.84% <0.00%> (ø)` | | | [tools/src/bin/apply-weight.rs](https://codecov.io/gh/LIHPC-Computational-Geometry/coupe/pull/286?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LIHPC-Computational-Geometry#diff-dG9vbHMvc3JjL2Jpbi9hcHBseS13ZWlnaHQucnM=) | `1.92% <0.00%> (ø)` | | | [tools/src/bin/mesh-refine.rs](https://codecov.io/gh/LIHPC-Computational-Geometry/coupe/pull/286?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LIHPC-Computational-Geometry#diff-dG9vbHMvc3JjL2Jpbi9tZXNoLXJlZmluZS5ycw==) | `2.22% <0.00%> (ø)` | | | [tools/src/bin/weight-gen.rs](https://codecov.io/gh/LIHPC-Computational-Geometry/coupe/pull/286?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LIHPC-Computational-Geometry#diff-dG9vbHMvc3JjL2Jpbi93ZWlnaHQtZ2VuLnJz) | `25.94% <0.00%> (ø)` | | | [tools/src/bin/mesh-reorder.rs](https://codecov.io/gh/LIHPC-Computational-Geometry/coupe/pull/286?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LIHPC-Computational-Geometry#diff-dG9vbHMvc3JjL2Jpbi9tZXNoLXJlb3JkZXIucnM=) | `1.31% <0.00%> (ø)` | | | [tools/src/bin/part-info.rs](https://codecov.io/gh/LIHPC-Computational-Geometry/coupe/pull/286?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LIHPC-Computational-Geometry#diff-dG9vbHMvc3JjL2Jpbi9wYXJ0LWluZm8ucnM=) | `0.45% <0.00%> (ø)` | | | [tools/src/bin/mesh-part.rs](https://codecov.io/gh/LIHPC-Computational-Geometry/coupe/pull/286?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LIHPC-Computational-Geometry#diff-dG9vbHMvc3JjL2Jpbi9tZXNoLXBhcnQucnM=) | `39.59% <0.00%> (ø)` | | | ... and [3 more](https://codecov.io/gh/LIHPC-Computational-Geometry/coupe/pull/286?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LIHPC-Computational-Geometry) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LIHPC-Computational-Geometry). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LIHPC-Computational-Geometry)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.