search

LIHPC-Computational-Geometry / gmds

GMDS, for Generic Mesh Data Structures and Services, provide a set of libraries to represent and handles meshes in the context of numerical simulation. It mainly targets quad and hex mesh generation and adaptation.
https://lihpc-computational-geometry.github.io/gmds/
GNU Lesser General Public License v2.1
27 stars 7 forks source link

fixed unitialized FACsurface and volume id, and replaced if statement… #284

Closed nicolaslg closed 1 year ago

nicolaslg commented 1 year ago

…s with std::min for bounding box computation

fix #283

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 95.00% and no project coverage change.

Comparison is base (634be99) 43.87% compared to head (ce8c1ab) 43.87%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #284 +/- ## ======================================= Coverage 43.87% 43.87% ======================================= Files 315 315 Lines 52622 52609 -13 ======================================= - Hits 23086 23083 -3 + Misses 29536 29526 -10 ``` | [Impacted Files](https://app.codecov.io/gh/LIHPC-Computational-Geometry/gmds/pull/284?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LIHPC-Computational-Geometry) | Coverage Δ | | |---|---|---| | [cadfac/src/FACSurface.cpp](https://app.codecov.io/gh/LIHPC-Computational-Geometry/gmds/pull/284?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LIHPC-Computational-Geometry#diff-Y2FkZmFjL3NyYy9GQUNTdXJmYWNlLmNwcA==) | `60.52% <85.71%> (-1.50%)` | :arrow_down: | | [cadfac/src/FACCurve.cpp](https://app.codecov.io/gh/LIHPC-Computational-Geometry/gmds/pull/284?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LIHPC-Computational-Geometry#diff-Y2FkZmFjL3NyYy9GQUNDdXJ2ZS5jcHA=) | `53.22% <100.00%> (+1.14%)` | :arrow_up: | | [cadfac/src/FACVolume.cpp](https://app.codecov.io/gh/LIHPC-Computational-Geometry/gmds/pull/284?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LIHPC-Computational-Geometry#diff-Y2FkZmFjL3NyYy9GQUNWb2x1bWUuY3Bw) | `88.88% <100.00%> (+0.42%)` | :arrow_up: | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/LIHPC-Computational-Geometry/gmds/pull/284/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LIHPC-Computational-Geometry)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.