search

LIHPC-Computational-Geometry / gmds

GMDS, for Generic Mesh Data Structures and Services, provide a set of libraries to represent and handles meshes in the context of numerical simulation. It mainly targets quad and hex mesh generation and adaptation.
https://lihpc-computational-geometry.github.io/gmds/
GNU Lesser General Public License v2.1
26 stars 5 forks source link

Potential mistake in Blocking2D structure when a new block is created #340

Open claireroche opened 10 months ago

claireroche commented 10 months ago

In the Blocking2D.cpp of folder ig/src ,

  1. When we want to create a block using newBlock function, I think there is a mistake while updating the connectivities.

I think lines 95-96: Node n3 = get<Node>(AN3); n1.add(b);

should be replace by Node n3 = get<Node>(AN3); n3.add(b);

  1. I think there is a second mistake, at l. 898: for(int j = 0; j<getNbDiscretizationI(); j++){

the limit should be on getNbDiscretizationJ()

create-issue-branch[bot] commented 10 months ago

Branch issue-340-Potential_mistake_in_Blocking2D_structure_when_a_new_block_is_created created!