LIHPC-Computational-Geometry / honeycomb

Combinatorial map implementation for meshing applications
https://lihpc-computational-geometry.github.io/honeycomb/
Apache License 2.0
7 stars 1 forks source link

refactor(core): replace attribute-related panics with warnings #178

Closed imrn99 closed 1 month ago

imrn99 commented 1 month ago

The PR has mixed content, the changes I started required more and more stuff to be changed as a consequence

Scope

Type of change

Other

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 82.41758% with 16 lines in your changes missing coverage. Please review.

Project coverage is 81.97%. Comparing base (4a5ed63) to head (95a0aea).

Files with missing lines Patch % Lines
honeycomb-core/src/attributes/collections.rs 71.42% 14 Missing :warning:
honeycomb-kernels/src/grisubal/model.rs 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #178 +/- ## ======================================= Coverage 81.96% 81.97% ======================================= Files 32 32 Lines 4503 4538 +35 ======================================= + Hits 3691 3720 +29 - Misses 812 818 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.