Closed imrn99 closed 4 weeks ago
Attention: Patch coverage is 84.60039%
with 158 lines
in your changes missing coverage. Please review.
Project coverage is 82.14%. Comparing base (
ab03601
) to head (e05579e
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@cedricchevalier19 I'm not sure whether doing review is relevant during the implementation process since code will move very fast
I think that rebasing this PR on a PR that just duplicates camp
in map
might make it easier to track changes due to parallelization.
BTW, why are you doing a separate data structure? Is it to benchmark the sequential behavior?
I added a separate data structure because I wanted to keep the sequential one that has "no overhead" due to sync mechanism. In retrospect, this might be counterproductive since:
I think I'll redo the changes in a PR where I modify the original struct. I can benchmark the "overhead" by checking out to 0.6.0
Closing this to reopen a cleaner PR with structure changes
Implemented:
POrbit2
), this should eventualy be common code withCMap2
From<CMap2>
impl forPMap2
Skipped:
part of #197
Necessary follow-up