Closed imrn99 closed 2 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 82.60%. Comparing base (
d79671f
) to head (fad1ca0
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I was just wondering if splitting the loop into (the interior domain and then the boundary (last row & last column)) can not make the code easier to read (and perhaps more efficient without a conditional in the middle).
I managed to reorganize the code by splitting like you suggested. I also extracted some common functions which should help with readability
It does not seem to make much of a difference performance-wise (maybe 5% better? but laptop numbers aren't really reliable)
link
usages withset_beta
usagesperformance changes for a 512x512 grid (exec time in ms):
157.11
89.83
92.98
24.54
246.48
120.16
121.79
35.54