search

LIHPC-Computational-Geometry / honeycomb

Combinatorial map implementation for meshing applications
https://lihpc-computational-geometry.github.io/honeycomb/
Apache License 2.0
7 stars 1 forks source link

test(core): add coverage over new parallel implementations #214

Closed imrn99 closed 1 week ago

imrn99 commented 2 weeks ago

this adds coverage over additions of #201

it also fixes a problem highlighted by the new tests; the two_unsew methods were not correctly dealing with vertex attributes

codecov-commenter commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 92.19331% with 42 lines in your changes missing coverage. Please review.

Project coverage is 81.73%. Comparing base (fdb2ed9) to head (df5b4eb).

Files with missing lines Patch % Lines
honeycomb-core/src/cmap/dim2/link_and_sew.rs 36.00% 32 Missing :warning:
honeycomb-core/src/attributes/tests.rs 98.21% 7 Missing :warning:
honeycomb-core/src/cmap/dim2/tests.rs 96.87% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #214 +/- ## ========================================== + Coverage 75.29% 81.73% +6.43% ========================================== Files 41 41 Lines 6376 6866 +490 ========================================== + Hits 4801 5612 +811 + Misses 1575 1254 -321 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

imrn99 commented 2 weeks ago

the windows CI has decided it won't run :+1: