LIHPC-Computational-Geometry / honeycomb

Combinatorial map implementation for meshing applications
https://lihpc-computational-geometry.github.io/honeycomb/
Apache License 2.0
7 stars 1 forks source link

refactor!: replace identifier type aliases with strong-typed structures #220

Open imrn99 opened 1 week ago

imrn99 commented 1 week ago

a lot of these changes are noise from examples & tests that used direct integer values as args

codecov-commenter commented 3 days ago

Codecov Report

Attention: Patch coverage is 91.57641% with 140 lines in your changes missing coverage. Please review.

Project coverage is 83.32%. Comparing base (43e2f22) to head (c5718e6).

Files with missing lines Patch % Lines
honeycomb-core/src/attributes/manager.rs 41.07% 66 Missing :warning:
honeycomb-core/src/cmap/dim2/link_and_sew.rs 67.74% 40 Missing :warning:
honeycomb-kernels/src/grisubal/routines/clip.rs 0.00% 11 Missing :warning:
honeycomb-core/src/cmap/dim2/utils.rs 16.66% 10 Missing :warning:
honeycomb-core/src/cmap/dim2/basic_ops.rs 93.10% 4 Missing :warning:
honeycomb-kernels/src/triangulation/fan.rs 42.85% 4 Missing :warning:
honeycomb-core/src/cmap/components/identifiers.rs 66.66% 3 Missing :warning:
honeycomb-core/src/attributes/collections.rs 93.93% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #220 +/- ## ========================================== + Coverage 81.89% 83.32% +1.43% ========================================== Files 48 48 Lines 6853 6921 +68 ========================================== + Hits 5612 5767 +155 + Misses 1241 1154 -87 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

imrn99 commented 3 days ago

putting this on hold until I figure out why the exec time is 20% higher on benchmarks