LIJI32 / SameBoy

Game Boy and Game Boy Color emulator written in C
https://sameboy.github.io/
Other
1.68k stars 211 forks source link

GBC mode SGB borders #385

Open brainard52 opened 3 years ago

brainard52 commented 3 years ago

There are some homebrews and ROM hacks that have SGB borders while in GBC mode. One example of this is Pokemon Crystal Clear. Is there any possibility of this being supported in SameBoy?

LIJI32 commented 3 years ago

This will be problematic to support without some formal standardization of this feature that prevents "standard" games from accidentally activating this feature and breaking the game. A formal specification of this feature safety measures against such cases is required before I can safely implement it.

ghost commented 3 years ago

https://github.com/ShockSlayer/ccdocs/blob/master/docs/changelogs/2_4_0_Changelog.md

BGB:

    In Options > Graphics > "show border", tick "only SGB border"
    In Options > System > "Emulated system", tick "SGB + GBC"

Goomba:

    By default, Goomba will not load the border. The following must be done on each boot (for now)

    Press L+R to open the Goomba menu
    In "Other Settings", set "Game Boy:" to "GBC+SGB"
    Return to the main menu and select "Restart"
    The border will now work correctly, however the graphics will glitch slightly when updating.

SameBoy:

Enable only if GBC + SGB unofficial model manually chosen? Not auto or GBC?

Aerocatia commented 3 years ago

The way BGB etc. do it is a kludge, they run the ROM in SGB mode until it uploads the border, then it resets it into GBC mode while keeping that border displayed.