search

LIJI32 / SameBoy

Game Boy and Game Boy Color emulator written in C
https://sameboy.github.io/
Other
1.68k stars 211 forks source link

CH3 sounds different from real DMG #413

Open jkotlinski opened 3 years ago

jkotlinski commented 3 years ago

While researching sample playback techniques, I noticed that SameBoy DMG and real DMG sound pretty different. Not sure if it's strictly a bug, but I thought it sounded different enough to warrant a report.

Tested with SameBoy 0.14.5.

Attaching gb + wav files: sampleproblem.zip

LIJI32 commented 3 years ago

Several channel 3 bugs were fixed in 0.14.6, can you confirm the bug reproduces on that version as well?

jkotlinski commented 3 years ago

Retested with 0.14.7 and it seems like the difference is still there.

jkotlinski commented 3 years ago

Also, it's probably not a "bug" it just seems like it doesn't sound quite the same. Looking at the waveforms closely, the spikes are pretty different.

jkotlinski commented 3 years ago

FYI, I discovered this difference when reviewing old techniques for improving sample playback quality. Some techniques seem to improve sound quality on real hardware, but make it worse on SameBoy.

On Sun, 31 Oct 2021 at 01:45, Lior Halphon @.***> wrote:

Several channel 3 bugs were fixed in 0.14.6, can you confirm the bug reproduces on that version as well?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/LIJI32/SameBoy/issues/413#issuecomment-955608691, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAY34O74N6ENFDD26IXZGN3UJR7RDANCNFSM5HBTGBVQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

jkotlinski commented 2 years ago

Closing this issue due to inactivity.

LIJI32 commented 2 years ago

I'd like to keep this issue open. It's not being ignored – it's just that audio research on pre-CGB devices is far more limited and requires a much more complicated hardware debugging setup. Due to this, this issue is not as prioritized as other issues, but I do want to eventually address it in the future.