LIJI32 / SameBoy

Game Boy and Game Boy Color emulator written in C
https://sameboy.github.io/
Other
1.65k stars 207 forks source link

Zombie mode inaccuracy on DMG #522

Closed jkotlinski closed 1 year ago

jkotlinski commented 1 year ago

test.gb.gz

The attached ROM sounds very different on Sameboy and a real DMG. (Please note, you need to wait a long time until the ROM produces a sound. Maybe it is possible to shorten the loop for test purposes.)

jkotlinski commented 1 year ago

It might be worth to test this ROM on CGB-C or earlier. I suspect the same inaccuracy is present on those revisions.

LIJI32 commented 1 year ago

I'll currently focus on CGB-C because DMG Zombie Mode is non-deterministic. It looks like my CGB-C and CGB-E both sound the same and match SameBoy in CGB-E mode, but SameBoy in CGB-C is completely broken. I'll have to look into that, thanks!

LIJI32 commented 1 year ago

It appears that while the test ROM produces an emulation inaccuracy only on CGB-C and older, this inaccuracy also exists in SameBoy's CGB-E emulation. This is a very nice catch!