LIJI32 / SameBoy

Game Boy and Game Boy Color emulator written in C
https://sameboy.github.io/
Other
1.58k stars 205 forks source link

Channel 3 (Wave) OFF not emulated correctly #538

Open coffeevalenbat opened 1 year ago

coffeevalenbat commented 1 year ago

So I've been messing around with getting the cleanest possible sample playback from channel 3, I modified some sample code from GB Studio and tried it out on a few emulators, at first I was happy that it sounded clean as water on Sameboy, as that's where I always test sound stuff first, but after I got some friends to test it on real hardware and other emulators, it seems like the issue is Sameboy being too good. It lacks the click noise heard while channel 3 is off (IE, when rAUD3ENA is 0). While this does make for a better sounding experience, it is also misleading and innacurate.

Sameboy:

https://user-images.githubusercontent.com/34352018/232251242-2f09321c-2d38-4b4c-b799-0d8d197d9123.mp4

MGBA (I cannot test on real hardware myself right now, but I was told real hardware [At least a GB Pocket] sounds like this):

https://user-images.githubusercontent.com/34352018/232251239-809bdfcc-1d0d-4a86-b1a3-6f98231b4be0.mp4

For testing, here is the ROM in question, the sample plays when the player presses the B button.

Buggem commented 1 year ago

I'm a bit confused here. Why is this guy in the top corner around 0 seconds in? AC81301E-3EE3-4704-B382-FBEA958620C3

coffeevalenbat commented 1 year ago

...that is my cursor :P

carmiker commented 9 months ago

For the record, Gambatte sounds like the second video posted (like mGBA or ostensibly real hardware).