Fix bugs in Makefile for newer operating systems

LIJI32 / SameBoy

Game Boy and Game Boy Color emulator written in C

https://sameboy.github.io/

Other

1.58k stars 205 forks source link

Fix bugs in Makefile for newer operating systems #579

Closed Buggem closed 6 months ago

Buggem commented 6 months ago

Follow up to my issue #578. A fix for 2 bugs I was facing when I built SameBoy on macOS Sonama.

Buggem commented 6 months ago

Note: this patch is only intended to be a fix if worse comes to worse, as it requires a password. But as it is only for building, this might not matter as much.

LIJI32 commented 6 months ago

This isn't very future (or past) proof, as the user might only have the 12.x or 14.x SDKs, grep "[0-9]\." is probably a better solution to get the latest numbered SDK.

Buggem commented 6 months ago

@LIJI32 updated as per code improvement

LIJI32 commented 6 months ago

I actually missed the $(shell sudo xcode-select -s /Applications/Xcode.app/Contents/Developer) line, why is this needed? It runs even if the previous line successfully found a Sysroot, and the following line will work regardless of the path reset.