Closed Rangi42 closed 3 months ago
Great work! I've been wanting to eventually clean SameBoot up and use hardware.inc more "fully", but I never had the chance, and you probably did a far better job than I would. I do have a few comments though:
git blame
up?ld hl, (BOOTUP_A_MGB << 8) | $B0
and co. could use the lb
macro.CgbFlag
, SgbFlag
, RomSize
and RamSize
should be CGBFlag
, SGBFlag
, ROMSize
and RAMSize
, respectively.
Bootrom code is updated to use new hardware.inc constants, as well as for consistent formatting.
The ROMs are unchanged:
These should still build with RGBDS 0.5.0 through 0.8.0 (master). Compatibility notes:
-i
, requiring-I
, so we just use the long--include
option.halt
without an implicitnop
after it requires version-specific flags. RGBASM 0.5.0 and 0.6.0 needed-h
to disable it; 0.7.0 does so by default. (0.7.0 lets you opt in with-H
, but 0.8.0 will remove that entirely.)