search

LIMO-EEG-Toolbox / limo_tools

Hierarchical Linear Modelling for MEEG data
https://limo-eeg-toolbox.github.io/limo_meeg/
Other
58 stars 27 forks source link

warndlg2() instead of warndlg() called in limo_batch_gui line 481 #73

Closed NirOfir closed 3 years ago

NirOfir commented 3 years ago

Not sure if it is intended or not. Is LIMO supposed to be able to run on a machine without EEGLAB? If so, I guess this call should be changed to warndlg() instead. Should I make a PR?

CPernet commented 3 years ago

I tried to curate the code, usually 

if ~exist('warndlg2',file)
    warndlg('...')
else
   warndlg2('...')
end

thanks for going through stuff --> https://github.com/LIMO-EEG-Toolbox/limo_tools/blob/master/contributors.md

PR to hotfixes is the way to go

NirOfir commented 3 years ago

Cool, will do. I see now that line 472 calls to warndlg() instead. Should I change both to this if solution (call warndlg2 if possible)?

CPernet commented 3 years ago

yes I use that bit of code above in many places but haven't been very systematic ... indeed the idea is that one may be able to call matlab/eeglab/fieldtrip depending on what's available

NirOfir commented 3 years ago

Thanks! I made the PR now.